Hi, all, If ACPI TZ is widely configured, this patch can be dropped, but I found most users don't have ACPI TZ in their machines. Huacai On Fri, Aug 19, 2022 at 8:59 AM Jianmin Lv <lvjianmin@xxxxxxxxxxx> wrote: > > > > On 2022/8/18 下午6:08, Xi Ruoyao wrote: > > On Thu, 2022-08-18 at 15:08 +0800, Jianmin Lv wrote: > >> I don't think we need the driver any more, we have thermal zone based > >> acpi which implemented more functions include the function here. > >> > >> And, the driver will conflict with acpi thermal > >> driver(drivers/acpi/thermal.c), which leads to confusion with users. > > > > Hmm... I reverted this in my local tree then the CPU temperature > > disappeared from /sys/class/hwmon. I have CONFIG_ACPI_THERMAL=y. Am I > > doing something wrong or we need to wait for a firmware update for the > > ACPI thermal zone device? > > > > Maybe your firmware does not config TZ, you can confirm that by checking > DSDT as following: > > cp /sys/firmware/acpi/tables/DSDT ./ > iasl DSDT > > and in produced DSDT.asl, check if TZ is in it. > > > > >
