Hi, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v6.0-rc1 next-20220818] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/guoren-kernel-org/riscv-kexec-Support-crash_save-percpu-and-machine_kexec_mask_interrupts/20220816-144442 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 config: riscv-buildonly-randconfig-r002-20220818 (https://download.01.org/0day-ci/archive/20220818/202208181655.NrkPo4lG-lkp@xxxxxxxxx/config) compiler: riscv64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0abdaf7e1f44634e1cee484e3cf01b7e8c851950 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review guoren-kernel-org/riscv-kexec-Support-crash_save-percpu-and-machine_kexec_mask_interrupts/20220816-144442 git checkout 0abdaf7e1f44634e1cee484e3cf01b7e8c851950 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from arch/riscv/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/elfcore.h:6, from include/linux/crash_core.h:6, from include/linux/kexec.h:18, from arch/riscv/kernel/machine_kexec.c:7: arch/riscv/kernel/machine_kexec.c: In function 'machine_kexec': >> arch/riscv/kernel/machine_kexec.c:217:14: error: implicit declaration of function 'smp_crash_stop_failed' [-Werror=implicit-function-declaration] 217 | WARN(smp_crash_stop_failed(), | ^~~~~~~~~~~~~~~~~~~~~ include/asm-generic/bug.h:174:32: note: in definition of macro 'WARN' 174 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ cc1: some warnings being treated as errors vim +/smp_crash_stop_failed +217 arch/riscv/kernel/machine_kexec.c 193 194 /* 195 * machine_kexec - Jump to the loaded kimage 196 * 197 * This function is called by kernel_kexec which is called by the 198 * reboot system call when the reboot cmd is LINUX_REBOOT_CMD_KEXEC, 199 * or by crash_kernel which is called by the kernel's arch-specific 200 * trap handler in case of a kernel panic. It's the final stage of 201 * the kexec process where the pre-loaded kimage is ready to be 202 * executed. We assume at this point that all other harts are 203 * suspended and this hart will be the new boot hart. 204 */ 205 void __noreturn 206 machine_kexec(struct kimage *image) 207 { 208 struct kimage_arch *internal = &image->arch; 209 unsigned long jump_addr = (unsigned long) image->start; 210 unsigned long first_ind_entry = (unsigned long) &image->head; 211 unsigned long this_cpu_id = __smp_processor_id(); 212 unsigned long this_hart_id = cpuid_to_hartid_map(this_cpu_id); 213 unsigned long fdt_addr = internal->fdt_addr; 214 void *control_code_buffer = page_address(image->control_code_page); 215 riscv_kexec_method kexec_method = NULL; 216 > 217 WARN(smp_crash_stop_failed(), -- 0-DAY CI Kernel Test Service https://01.org/lkp
