Hi Huacai, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v6.0-rc1 next-20220815] [cannot apply to soc/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/LoongArch-Use-TLB-for-ioremap/20220815-204842 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20220816/202208160215.TXzFu9Xd-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0cdab71896d6b3b3b3f540f80d6f041a0c592e7a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Huacai-Chen/LoongArch-Use-TLB-for-ioremap/20220815-204842 git checkout 0cdab71896d6b3b3b3f540f80d6f041a0c592e7a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash arch/loongarch/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): arch/loongarch/mm/init.c: In function 'fixmap_pte': >> arch/loongarch/mm/init.c:171:24: warning: variable 'new' set but not used [-Wunused-but-set-variable] 171 | pud_t *new; | ^~~ >> arch/loongarch/mm/init.c:187:26: warning: passing argument 1 of 'pmd_init' makes integer from pointer without a cast [-Wint-conversion] 187 | pmd_init(new); | ^~~ | | | pmd_t * In file included from include/linux/pgtable.h:6, from include/linux/mm.h:29, from include/linux/pagemap.h:8, from arch/loongarch/mm/init.c:14: arch/loongarch/include/asm/pgtable.h:245:36: note: expected 'long unsigned int' but argument is of type 'pmd_t *' 245 | extern void pmd_init(unsigned long page, unsigned long pagetable); | ~~~~~~~~~~~~~~^~~~ arch/loongarch/mm/init.c:187:17: error: too few arguments to function 'pmd_init' 187 | pmd_init(new); | ^~~~~~~~ In file included from arch/loongarch/mm/init.c:35: arch/loongarch/include/asm/pgalloc.h:48:13: note: declared here 48 | extern void pmd_init(unsigned long page, unsigned long pagetable); | ^~~~~~~~ vim +/new +171 arch/loongarch/mm/init.c 159 160 static pte_t *fixmap_pte(unsigned long addr) 161 { 162 pgd_t *pgd; 163 p4d_t *p4d; 164 pud_t *pud; 165 pmd_t *pmd; 166 167 pgd = pgd_offset_k(addr); 168 p4d = p4d_offset(pgd, addr); 169 170 if (pgd_none(*pgd)) { > 171 pud_t *new; 172 173 new = memblock_alloc_low(PAGE_SIZE, PAGE_SIZE); 174 pgd_populate(&init_mm, pgd, new); 175 #ifndef __PAGETABLE_PUD_FOLDED 176 pud_init(new); 177 #endif 178 } 179 180 pud = pud_offset(p4d, addr); 181 if (pud_none(*pud)) { 182 pmd_t *new; 183 184 new = memblock_alloc_low(PAGE_SIZE, PAGE_SIZE); 185 pud_populate(&init_mm, pud, new); 186 #ifndef __PAGETABLE_PMD_FOLDED > 187 pmd_init(new); 188 #endif 189 } 190 191 pmd = pmd_offset(pud, addr); 192 if (pmd_none(*pmd)) { 193 pte_t *new; 194 195 new = memblock_alloc_low(PAGE_SIZE, PAGE_SIZE); 196 pmd_populate_kernel(&init_mm, pmd, new); 197 } 198 199 return pte_offset_kernel(pmd, addr); 200 } 201 -- 0-DAY CI Kernel Test Service https://01.org/lkp
