On Tue, 2022-07-26 at 21:10 +0800, WANG Xuerui wrote: > On 2022/7/26 21:02, Huacai Chen wrote: > > Disable executable stack for LoongArch by default, as all modern > > architectures do. > > I don't know why this slipped in under everyone's eyes... Struggling > to > recall some of my mental activities during the initial review, I may > be > not too familiar with the code at that time (maybe still the case > now), > and didn't check what exactly "read_implies_exec" means in this > particular context. That could be just the reason for my part. > > But better mention the discussion leading to the discovery of this > bug: > "The problematic behavior was initially discovered by Andreas Schwab > in > a binutils discussion [1], fix suggested by WANG Xuerui" or something > along the line. > > [1]: https://sourceware.org/pipermail/binutils/2022-July/121992.html I think we already have a "standard" format for this: "Reported-by: Andreas Schwab <...>" "Suggested-by: Wang Xuerui <...>" "Url: https://sourceware.org/pipermail/binutils/2022-July/121992.html"; Tested on my A2101 board and nothing is broken so far. Tested-by: Xi Ruoyao <xry111@xxxxxxxxxxx> -- Xi Ruoyao <xry111@xxxxxxxxxxx> School of Aerospace Science and Technology, Xidian University
