On Mon, Jul 25, 2022 at 12:10:59PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 25, 2022 at 11:07:35AM +0900, Stafford Horne wrote: > > When building OpenRISC PCI which has no ioport_map we get the following build > > error. > > > > lib/pci_iomap.c: In function 'pci_iomap_range': > > CC drivers/i2c/i2c-core-base.o > > ./include/asm-generic/pci_iomap.h:29:41: error: implicit declaration of function 'ioport_map'; did you mean 'ioremap'? [-Werror=implicit-function-declaration] > > 29 | #define __pci_ioport_map(dev, port, nr) ioport_map((port), (nr)) > > | ^~~~~~~~~~ > > lib/pci_iomap.c:44:24: note: in expansion of macro '__pci_ioport_map' > > 44 | return __pci_ioport_map(dev, start, len); > > | ^~~~~~~~~~~~~~~~ > > > > This patch adds a NULL definition of __pci_ioport_map for architetures > > which do not support ioport_map. > > > > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx> > > Signed-off-by: Stafford Horne <shorne@xxxxxxxxx> > > FWIW, > > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> Thank you, > I assume this will go via some other tree; let me know if otherwise. Yes I plan to send this along with the other patches via the OpenRISC tree. -Stafford
