On Wed, Jul 20, 2022 at 10:19:34PM +0900, Stafford Horne wrote: > The asm/pci.h used for many newer architectures share similar > definitions. Move the common parts to asm-generic/pci.h to allow for > sharing code. > > One thing to note: > > - ARCH_GENERIC_PCI_MMAP_RESOURCE, csky does not define this so we > undefine it after including asm-generic/pci.h. Why doesn't csky > define it? > > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx> > Link: https://lore.kernel.org/lkml/CAK8P3a0JmPeczfmMBE__vn=Jbvf=nkbpVaZCycyv40pZNCJJXQ@xxxxxxxxxxxxxx/ > Acked-by: Pierre Morel <pmorel@xxxxxxxxxxxxx> > Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Signed-off-by: Stafford Horne <shorne@xxxxxxxxx> > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h > index 0aebc3488c32..016eb6b46dc0 100644 > --- a/arch/arm64/include/asm/pci.h > +++ b/arch/arm64/include/asm/pci.h > -extern int isa_dma_bridge_buggy; Shouldn't this go in the previous patch? The only definition of a isa_dma_bridge_buggy variable is in drivers/pci/pci.c, and it's under #ifdef CONFIG_X86_32. Same for csky, riscv, um?
