On Tue, Jul 19, 2022 at 03:18:17PM +0200, Arnd Bergmann wrote: > On Tue, Jul 19, 2022 at 3:05 PM Stafford Horne <shorne@xxxxxxxxx> wrote: > > On Tue, Jul 19, 2022 at 09:23:36PM +0900, Stafford Horne wrote: > > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > > > > And this is the result, I will get this into the series and create a v4 tomorrow > > if no issues. > > Looks good to me, just one detail: > > > diff --git a/include/linux/isa-dma.h b/include/linux/isa-dma.h > > new file mode 100644 > > index 000000000000..9514f0949fa1 > > --- /dev/null > > +++ b/include/linux/isa-dma.h > > @@ -0,0 +1,12 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > + > > +#ifndef __LINUX_ISA_DMA_H > > +#define __LINUX_ISA_DMA_H > > + > > +#if defined(CONFIG_PCI) && defined(CONFIG_X86_32) > > +extern int isa_dma_bridge_buggy; > > +#else > > +#define isa_dma_bridge_buggy (0) > > +#endif > > + > > +#endif /* __LINUX_ISA_DMA_H */ > > I would make this file #include <asm/dma.h> as a step towards making > linux/isa-dma.h the official replacement for it in the driver api. > > Including asm/dma.h from a driver is already a bit awkward, since we > are generally moving towards including only linux/*.h type headers, and > the dma.h name is too generic for something that is completely obsolete. OK, that makes sense. Then I can remove the asm/dma.h include from: - drivers/comedi/drivers/comedi_isadma.c - sound/core/isadma.c -Stafford
