+CC Palmer's current email (idk if his google one directs, but JIC) On 07/07/2022 13:13, Arnd Bergmann wrote: > On Thu, Jul 7, 2022 at 1:40 PM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote: >> >> On Wed, Oct 6, 2021 at 6:52 PM Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx> wrote: >>> >>> On Wed, 06 Oct 2021 08:17:38 PDT (-0700), Arnd Bergmann wrote: >>>> On Wed, Oct 6, 2021 at 5:00 PM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote: >>>>> >>>>> Commit 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()") >>>>> introduces the config symbol GENERIC_LIB_DEVMEM_IS_ALLOWED, but then >>>>> falsely refers to CONFIG_GENERIC_DEVMEM_IS_ALLOWED (note the missing LIB >>>>> in the reference) in ./include/asm-generic/io.h. >>>>> >>>>> Luckily, ./scripts/checkkconfigsymbols.py warns on non-existing configs: >>>>> >>>>> GENERIC_DEVMEM_IS_ALLOWED >>>>> Referencing files: include/asm-generic/io.h >>>>> >>>>> Correct the name of the config to the intended one. >>>>> >>>>> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()") >>>>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> >>>> >>>> Acked-by: Arnd Bergmann <arnd@xxxxxxxx> >>> >>> Reviewed-by: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx> >>> Acked-by: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx> >>> >>> Thanks. I'm going to assume this is going in through some other tree, >>> but IIUC I sent the buggy patch up so LMK if you're expecting it to go >>> through mine. >> >> Palmer, Arnd, >> >> the patch in this mail thread got lost and was not picked up yet. >> >> MAINTAINERS suggests that Arnd takes patches to include/asm-generic/, >> since commit 1527aab617af ("asm-generic: list Arnd as asm-generic >> maintainer") in 2009, but maybe the responsibility for those files has >> actually moved on to somebody (or nobody) else and we just did not >> record that yet in MAINTAINERS. >> >> Arnd, will you pick this patch and provide it further to Linus Torvalds? >> >> Otherwise, Palmer already suggested picking it up himself. >> > > I've applied it to the asm-generic tree and can send it as a bugfix > pull request. I don't have any other fixer for that branch at the moment, > so if Palmer has other fixes for the riscv tree already, it would > save me making a pull request if he picks it up there. > > Arnd