Re: [PATCH v7 0/6] Add RS485 9th bit addressing mode support to DW UART

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 15, 2022 at 2:52 PM Ilpo Järvinen
<ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
>
> This patchset adds RS-485 9th bit addressing mode support to the DW
> UART driver and the necessary serial core bits to handle it. The
> addressing mode is configured through .rs485_config() as was requested
> during the review of the earlier versions. The line configuration
> related ADDRB is still kept in ktermios->c_cflag to be able to take
> account the extra addressing bit while calculating timing, etc. but it
> is set/cleared by .rs485_config().
>
> PLEASE CHECK that the serial_rs485 .padding change looks OK (mainly
> that it won't add hole under some odd condition which would alter
> serial_rs485's sizeof)!

Have you had a chance to run `pahole` [1][2]?

[1]: https://linux.die.net/man/1/pahole
[2]: https://git.kernel.org/pub/scm/devel/pahole/pahole.git

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux