On 6/6/22 02:41, Arnd Bergmann wrote:
From: Arnd Bergmann<arnd@xxxxxxxx>
The BusLogic driver is the last remaining driver that relies on the
deprecated bus_to_virt() function, which in turn only works on a few
architectures, and is incompatible with both swiotlb and iommu support.
Before commit 391e2f25601e ("[SCSI] BusLogic: Port driver to 64-bit."),
the driver had a dependency on x86-32, presumably because of this
problem. However, the change introduced another bug that made it still
impossible to use the driver on any 64-bit machine.
This was in turn fixed in commit 56f396146af2 ("scsi: BusLogic: Fix
64-bit system enumeration error for Buslogic"), 8 years later.
The fact that this was found at all is an indication that there are
users, and it seems that Maciej, Matt and Khalid all have access to
this hardware, but if it took eight years to find the problem,
it's likely that nobody actually relies on it.
Remove it as part of the global virt_to_bus()/bus_to_virt() removal.
If anyone is still interested in keeping this driver, the alternative
is to stop it from using bus_to_virt(), possibly along the lines of
how dpt_i2o gets around the same issue.
Cc: Maciej W. Rozycki<macro@xxxxxxxxxxx>
Cc: Matt Wang<wwentao@xxxxxxxxxx>
Cc: Khalid Aziz<khalid@xxxxxxxxxxxxxx>
Signed-off-by: Arnd Bergmann<arnd@xxxxxxxx>
---
Documentation/scsi/BusLogic.rst | 581 ---
Documentation/scsi/FlashPoint.rst | 176 -
MAINTAINERS | 7 -
drivers/scsi/BusLogic.c | 3727 --------------
drivers/scsi/BusLogic.h | 1284 -----
drivers/scsi/FlashPoint.c | 7560 -----------------------------
drivers/scsi/Kconfig | 24 -
7 files changed, 13359 deletions(-)
delete mode 100644 Documentation/scsi/BusLogic.rst
delete mode 100644 Documentation/scsi/FlashPoint.rst
delete mode 100644 drivers/scsi/BusLogic.c
delete mode 100644 drivers/scsi/BusLogic.h
delete mode 100644 drivers/scsi/FlashPoint.c
I would say no to removing BusLogic driver. Virtualbox is another
consumer of this driver. This driver is very old but I would rather fix
the issues than remove it until we do not have any users.
Thanks,
Khalid
