Hi, Xuerui,
On Sat, Jun 4, 2022 at 4:39 PM WANG Xuerui <kernel@xxxxxxxxxx> wrote:
>
> On 6/4/22 16:06, Huacai Chen wrote:
> > Commit c5febea0956fd387 ("fork: Pass struct kernel_clone_args into
> > copy_thread") change the prototype of copy_thread() and cause build
> > error, fix it.
> >
> > Fixes: c5febea0956fd387 ("fork: Pass struct kernel_clone_args into copy_thread")
> > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> > ---
> > arch/loongarch/kernel/process.c | 7 +++++--
> > include/linux/efi.h | 1 +
> > include/linux/pe.h | 2 ++
> > 3 files changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/loongarch/kernel/process.c b/arch/loongarch/kernel/process.c
> > index 6d944d65f600..5e090ffd16b9 100644
> > --- a/arch/loongarch/kernel/process.c
> > +++ b/arch/loongarch/kernel/process.c
> > @@ -120,10 +120,13 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
> > /*
> > * Copy architecture-specific thread state
> > */
> > -int copy_thread(unsigned long clone_flags, unsigned long usp,
> > - unsigned long kthread_arg, struct task_struct *p, unsigned long tls)
> > +int copy_thread(struct task_struct *p, const struct kernel_clone_args *args)
> > {
> > unsigned long childksp;
> > + unsigned long tls = args->tls;
> > + unsigned long usp = args->stack;
> > + unsigned long clone_flags = args->flags;
> > + unsigned long kthread_arg = args->stack_size;
> > struct pt_regs *childregs, *regs = current_pt_regs();
> >
> > childksp = (unsigned long)task_stack_page(p) + THREAD_SIZE - 32;
> Please confirm if the patch is inadvertently truncated? I see there are
> 3 files in the diffstat, yet only one hunk below.
I'm sorry, this is my fault.
Huacai
