> > > > Just to make sure I don't misunderstand - for example for "kmsan: mm: > > call KMSAN hooks from SLUB code", would it be better to pull the code > > in mm/kmsan/core.c implementing kmsan_slab_alloc() and > > kmsan_slab_free() into that patch? > > Yes. > > > I thought maintainers would prefer to have patches to their code > > separated from KMSAN code, but if it's not true, I can surely fix > > that. > > As a maintainer, I want to know what the function call that you just > added to my subsystem to call does. Wouldn't you? Put it all in the > same patch. Ok, will be done in v2, thanks! > Think about submitting a patch series as telling a story. You need to > show the progression forward of the feature so that everyone can > understand what is going on. To just throw tiny snippets at us is > impossible to follow along with what your goal is. > > You want reviewers to be able to easily see if the things you describe > being done in the changelog actually are implemented in the diff. > Dividing stuff up by files does not show that at all. > > thanks, > > greg k-h -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.
