On Mon, Mar 07, 2022 at 04:00:15PM -0800, Kees Cook wrote: > On Mon, Feb 28, 2022 at 01:06:05PM +0000, Mark Brown wrote: > > static inline int arch_parse_elf_property(u32 type, const void *data, > > size_t datasz, bool compat, > > + bool has_interp, bool is_interp, > > struct arch_elf_state *arch) > Adding more and more args to a functions like this gives me the sense > that some kind of argument structure is needed. > Once I get enough unit testing written in here, I'm hoping to refactor > a bunch of this. To the future! :) Yes, this code is not lovely. I'll leave cleanups to future work though, it seems out of scope here and I'm not sure how good an idea it is to do too much without more solid testing.
Attachment:
signature.asc
Description: PGP signature
