Arnd Bergmann <arnd@xxxxxxxxxx> writes: > On Fri, Feb 11, 2022 at 6:46 PM Linus Torvalds > <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: >> On Fri, Feb 11, 2022 at 9:00 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: >> > >> > I have now uploaded a cleanup series to >> > https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=set_fs >> > >> > This uses the same access_ok() function across almost all >> > architectures, with the exception of those that need something else, >> > and I then I went further and killed off set_fs for everything other >> > than ia64. >> >> Thanks, looks good to me. >> >> Can you say why you didn't convert ia64? I don't see any set_fs() use >> there, except for the unaligned handler, which looks trivial to >> remove. It looks like the only reason for it is kernel-mode unaligned >> exceptions, which we should just turn fatal, I suspect (they already >> get logged). >> >> And ia64 people could make the unaligned handling do the kernel mode >> case in emulate_load/store_int() - it doesn't look *that* painful. >> >> But maybe you noticed something else? >> >> It would be really good to just be able to say that set_fs() no longer >> exists at all. > > I had previously gotten stuck at ia64, but gave it another go now > and uploaded an updated branch with ia64 taken care of and another > patch to clean up bits afterwards. > > I only gave it light testing so far, mainly building the defconfig for every > architecture. I'll post the series once the build bots are happy with the > branch overall. > Thank you so much for doing this work. Eric
