Al Viro <viro@xxxxxxxxxxxxxxxxxx> writes: > On Wed, Jan 05, 2022 at 05:48:08AM +0000, Al Viro wrote: >> On Wed, Dec 08, 2021 at 02:25:25PM -0600, Eric W. Biederman wrote: >> > The beginning of do_exit has become cluttered and difficult to read as >> > it is filled with checks to handle things that can only happen when >> > the kernel is operating improperly. >> > >> > Now that we have a dedicated function for cleaning up a task when the >> > kernel is operating improperly move the checks there. >> >> Umm... I would probably take profile_task_exit() crap out before that >> point. >> 1) the damn thing is dead - nothing registers notifiers there >> 2) blocking_notifier_call_chain() is not a nice thing to do on oops... >> >> I'll post a patch ripping the dead parts of kernel/profile.c out tomorrow >> morning (there's also profile_handoff_task(), equally useless these days >> and complicating things for __put_task_struct()). > > Argh... OK, so your subsequent series had pretty much the same thing. > My apologies - still digging myself out from mail pile that had accumulated > over two months ;-/ No worries. I really appreciate getting some detail review. Some things just take another set of eyes to spot. Eric
