On Wednesday, December 15, 2021 8:35 AM,
Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>
> On Thu, Nov 18, 2021 at 12:51:28AM -0800, Sunil Muthuswamy wrote:
>
> > Sunil Muthuswamy (2):
> > PCI: hv: Make the code arch neutral by adding arch specific interfaces
> > arm64: PCI: hv: Add support for Hyper-V vPCI
>
> Both patches are primarily to drivers/pci/controller/pci-hyperv.c, so
> why do the subject lines look so different?
>
> Instead of making up a new format from scratch, look at the previous
> history and copy it:
>
> $ git log --oneline drivers/pci/controller/pci-hyperv.c
> f18312084300 ("PCI: hv: Remove unnecessary use of %hx")
> 41608b64b10b ("PCI: hv: Fix sleep while in non-sleep context when removing
> child devices from the bus")
> 88f94c7f8f40 ("PCI: hv: Turn on the host bridge probing on ARM64")
> 9e7f9178ab49 ("PCI: hv: Set up MSI domain at bridge probing time")
> 38c0d266dc80 ("PCI: hv: Set ->domain_nr of pci_host_bridge at probing time")
> 418cb6c8e051 ("PCI: hv: Generify PCI probing")
> 8f6a6b3c50ce ("PCI: hv: Support for create interrupt v3")
> 7d815f4afa87 ("PCI: hv: Add check for hyperv_initialized in init_hv_pci_drv()")
> 326dc2e1e59a ("PCI: hv: Remove bus device removal unused
> refcount/functions")
> ...
>
> The second patch adds arm64 support, so it *should* mention arm64, but
> it can be something like this:
>
> PCI: hv: Add arm64 Hyper-V vPCI support
>
> > arch/arm64/include/asm/hyperv-tlfs.h | 9 +
> > arch/x86/include/asm/hyperv-tlfs.h | 33 ++++
> > arch/x86/include/asm/mshyperv.h | 7 -
> > drivers/pci/Kconfig | 2 +-
> > drivers/pci/controller/Kconfig | 2 +-
> > drivers/pci/controller/pci-hyperv.c | 281 ++++++++++++++++++++++++---
> > include/asm-generic/hyperv-tlfs.h | 33 ----
> > 7 files changed, 300 insertions(+), 67 deletions(-)
Thanks. If I am reading your feedback above correctly, the only correction
you are suggesting is to rename the subject line of the second patch to fix
the format. Otherwise, the subject lines of the patches describe what they
do. I will address this in v7.
- Sunil
