On Thu, Sep 30, 2021 at 01:27:20PM -0500, Tom Lendacky wrote: > > + if ((ghcb->save.sw_exit_info_1 & 0xffffffff) == 1) > > Really, any non-zero value indicates an error, so this should be: > > if (ghcb->save.sw_exit_info_1 & 0xffffffff) That's ok but that should be a separate patch - first patch splits the function and second changes the functionality. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette