From: Arnd Bergmann <arnd@xxxxxxxx>
This is the fifth version of my series, now spanning four patches
instead of two, with a new approach for handling struct ifreq
compatibility after I realized that my earlier approach introduces
additional problems.
The idea here is to always push down the compat conversion
deeper into the call stack: rather than pretending to be
native mode with a modified copy of the original data on
the user space stack, have the code that actually works on
the data understand the difference between native and compat
versions.
I have spent a long time looking at all drivers that implement
an ndo_do_ioctl callback to verify that my assumptions are
correct. This has led to a series of ~30 additional patches
that I am not including here but will post separately, fixing
a number of bugs in SIOCDEVPRIVATE ioctls, removing dead
code, and splitting ndo_do_ioctl into multiple new ndo callbacks
for private and ethernet specific commands.
Arnd
Link: https://lore.kernel.org/netdev/20201124151828.169152-1-arnd@xxxxxxxxxx/
Changes in v6:
- Split out and expand linux/compat.h rework
- Split ifconf change into two patches
- Rebase on latest net-next/master
Changes in v5:
- Rebase to v5.14-rc2
- Fix a few build issues
Changes in v4:
- build fix without CONFIG_INET
- build fix without CONFIG_COMPAT
- style fixes pointed out by hch
Changes in v3:
- complete rewrite of the series
Arnd Bergmann (6):
compat: make linux/compat.h available everywhere
ethtool: improve compat ioctl handling
net: socket: rework SIOC?IFMAP ioctls
net: socket: remove register_gifconf
net: socket: simplify dev_ifconf handling
net: socket: rework compat_ifreq_ioctl()
arch/arm64/include/asm/compat.h | 14 +-
arch/mips/include/asm/compat.h | 24 ++-
arch/parisc/include/asm/compat.h | 14 +-
arch/powerpc/include/asm/compat.h | 11 --
arch/s390/include/asm/compat.h | 14 +-
arch/sparc/include/asm/compat.h | 14 +-
arch/x86/include/asm/compat.h | 14 +-
arch/x86/include/asm/signal.h | 1 +
include/asm-generic/compat.h | 17 ++
include/linux/compat.h | 32 ++--
include/linux/ethtool.h | 4 -
include/linux/inetdevice.h | 9 +
include/linux/netdevice.h | 12 +-
net/appletalk/ddp.c | 4 +-
net/core/dev_ioctl.c | 153 +++++++++-------
net/ethtool/ioctl.c | 136 ++++++++++++--
net/ieee802154/socket.c | 4 +-
net/ipv4/af_inet.c | 6 +-
net/ipv4/devinet.c | 4 +-
net/qrtr/qrtr.c | 4 +-
net/socket.c | 292 +++++++-----------------------
21 files changed, 352 insertions(+), 431 deletions(-)
--
2.29.2
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Andrew Lunn <andrew@xxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
Cc: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Marco Elver <elver@xxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: linux-arch@xxxxxxxxxxxxxxx
Cc: netdev@xxxxxxxxxxxxxxx
