Re: [PATCH 3/9] signal/seccomp: Dump core when there is only one live thread

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: Re: [PATCH 3/9] signal/seccomp: Dump core when there is only one live thread
From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Fri, 25 Jun 2021 20:20:29 -0700
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Michael Schmitz <schmitzmic@xxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, alpha <linux-alpha@xxxxxxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, linux-m68k <linux-m68k@xxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxxxx>, Ley Foon Tan <ley.foon.tan@xxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>
In-reply-to: <87lf6z6qbd.fsf_-_@disp2133>
References: <YNCaMDQVYB04bk3j@zeniv-ca.linux.org.uk> <YNDhdb7XNQE6zQzL@zeniv-ca.linux.org.uk> <CAHk-=whAsWXcJkpMM8ji77DkYkeJAT4Cj98WBX-S6=GnMQwhzg@mail.gmail.com> <87a6njf0ia.fsf@disp2133> <CAHk-=wh4_iMRmWcao6a8kCvR0Hhdrz+M9L+q4Bfcwx9E9D0huw@mail.gmail.com> <87tulpbp19.fsf@disp2133> <CAHk-=wi_kQAff1yx2ufGRo2zApkvqU8VGn7kgPT-Kv71FTs=AA@mail.gmail.com> <87zgvgabw1.fsf@disp2133> <875yy3850g.fsf_-_@disp2133> <87lf6z6qbd.fsf_-_@disp2133>

On Thu, Jun 24, 2021 at 02:00:22PM -0500, Eric W. Biederman wrote:
> Replace get_nr_threads with atomic_read(&current->signal->live) as
> that is a more accurate number that is decremented sooner.

Okay, seems fine to me. :)

-- 
Kees Cook

References:
- Re: Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads
  - From: Al Viro
- Re: Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads
  - From: Al Viro
- Re: Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads
  - From: Linus Torvalds
- Re: Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads
  - From: Eric W. Biederman
- Re: Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads
  - From: Linus Torvalds
- Re: Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads
  - From: Eric W. Biederman
- Re: Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads
  - From: Linus Torvalds
- Re: Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads
  - From: Eric W. Biederman
- [PATCH 0/9] Refactoring exit
  - From: Eric W. Biederman
- [PATCH 3/9] signal/seccomp: Dump core when there is only one live thread
  - From: Eric W. Biederman

Prev by Date: Re: [PATCH 2/9] signal/seccomp: Refactor seccomp signal and coredump generation
Next by Date: Re: [PATCH 4/9] signal: Factor start_group_exit out of complete_signal
Previous by thread: [PATCH 3/9] signal/seccomp: Dump core when there is only one live thread
Next by thread: [PATCH 4/9] signal: Factor start_group_exit out of complete_signal
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]