On Fri, Jun 11, 2021 at 10:49:56AM +0200, Geert Uytterhoeven wrote: > Hoi Peter, > > Thanks for your patch! > > On Fri, Jun 11, 2021 at 10:36 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > Replace a bunch of 'p->state == TASK_RUNNING' with a new helper: > > task_is_running(p). > > You're also sticking a READ_ONCE() in the helper, which wasn't done > by any of the old implementations? Care to mention why? Patch 7/7 should clarify. Arguably I should leave the READ_ONCE() off here and only add it there.
