On Mon, Jun 7, 2021 at 3:29 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Mon, Jun 7, 2021 at 9:20 AM Maxime Ripard <maxime@xxxxxxxxxx> wrote: > > On Sun, Jun 06, 2021 at 09:04:08AM +0000, guoren@xxxxxxxxxx wrote: > > > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > > > index ed96376..055fb3e 100644 > > > --- a/arch/riscv/Kconfig.socs > > > +++ b/arch/riscv/Kconfig.socs > > > @@ -69,4 +69,16 @@ config SOC_CANAAN_K210_DTB_SOURCE > > > > > > endif > > > > > > +config SOC_SUNXI > > > + bool "Allwinner SoCs" > > > + depends on MMU > > > + select DWMAC_GENERIC > > > + select SERIAL_8250 > > > + select SERIAL_8250_CONSOLE > > > + select SERIAL_8250_DW > > > + select SIFIVE_PLIC > > > + select STMMAC_ETH > > > + help > > > + This enables support for Allwinner SoC platforms like the D1. > > > + > > > > We probably don't want to select DWMAC, STMMAC_ETH and the 8250 options, > > looks good otherwise. > > Correct: those subsystems may be completely disabled, which would lead to a > build failure, and a platform should not force-enable drivers or > subsystems unless > those are build time dependencies. > > Arnd I see, thx. how about just leave. I think the user would make mistakes and waste time here. select SERIAL_8250_DW if SERIAL_8250 -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/
