On Sat, May 8, 2021 at 12:11 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > I've included this patch in the series because Linus asked about > removing the byteshift version, but after trying it out, I'd > prefer to drop this and use the byteshift version for the > generic code as well. Update: I've tried to create a small test case that illustrates the problem with using the swab() based version, however all cases combinations I tried showed either both producing identical output, or the shift version being worse, see https://godbolt.org/z/bTdsjnjfT I'll rewrite the patch description accordingly and leave this in place. Arnd