On Fri, Apr 02, 2021 at 10:07:36PM +0530, Syed Nayyar Waris wrote: > This patch reimplements the xgpio_set_multiple() function in > drivers/gpio/gpio-xilinx.c to use the new generic functions: > bitmap_get_value() and bitmap_set_value(). The code is now simpler > to read and understand. Moreover, instead of looping for each bit > in xgpio_set_multiple() function, now we can check each channel at > a time and save cycles. As promised, I have looked at this with a fresh eye and NAK from me. Sorry. This is less than a half baked solution. I spent couple of evenings, so I'll come up with full conversion of this driver to the bitmap API. And yes, as I have told you like half a year before, bitmap_get_value32() and bitmap_set_value32() is much more useful (and I actually implemented them locally for the sake of conversion). So, summarize this I do not think we have real users of the proposed API. -- With Best Regards, Andy Shevchenko
