On Wed, Apr 7, 2021 at 2:35 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> It seems that no one ever checked in the nds32 install script so trying
> to build a nds32 kernel would never quite work properly as 'make
> install' would fail to run.
>
> Fix that up by having nds32 call the common install.sh script.
>
> Cc: Nick Hu <nickhu@xxxxxxxxxxxxx>
> Cc: Greentime Hu <green.hu@xxxxxxxxx>
> Cc: Vincent Chen <deanbo422@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> arch/nds32/boot/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/nds32/boot/Makefile b/arch/nds32/boot/Makefile
> index c4cc0c2689f7..8371e02f6091 100644
> --- a/arch/nds32/boot/Makefile
> +++ b/arch/nds32/boot/Makefile
> @@ -8,9 +8,9 @@ $(obj)/Image.gz: $(obj)/Image FORCE
> $(call if_changed,gzip)
>
> install: $(obj)/Image
> - $(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
> + $(CONFIG_SHELL) $(srctree)/scripts/install.sh $(KERNELRELEASE) \
> $(obj)/Image System.map "$(INSTALL_PATH)"
>
> zinstall: $(obj)/Image.gz
> - $(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
> + $(CONFIG_SHELL) $(srctree)/scripts/install.sh $(KERNELRELEASE) \
> $(obj)/Image.gz System.map "$(INSTALL_PATH)"
> --
> 2.31.1
>
Even with this patch, the 'install' target does not work.
$ make ARCH=nds32 install
make: *** No rule to make target 'install'. Stop.
If you really want to fix it, you need
to add something like follows:
diff --git a/arch/nds32/Makefile b/arch/nds32/Makefile
index ccdca7142020..3486b78da9ca 100644
--- a/arch/nds32/Makefile
+++ b/arch/nds32/Makefile
@@ -53,6 +53,9 @@ core-y += $(boot)/dts/
Image: vmlinux
$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
+PHONY += install zinstall
+install zinstall:
+ $(Q)$(MAKE) $(build)=$(boot) $@
PHONY += vdso_install
vdso_install:
Anyway, I agree that nds32 installation targets are
terribly broken.
--
Best Regards
Masahiro Yamada
