On Wed, Mar 17, 2021 at 07:40:04AM +0100, Lukas Bulwahn wrote: > On Wed, Mar 17, 2021 at 5:57 AM Joe Perches <joe@xxxxxxxxxxx> wrote: > > > > On Tue, 2021-03-16 at 21:47 -0700, Yury Norov wrote: > > > [CC Andy Whitcroft, Joe Perches, Dwaipayan Ray, Lukas Bulwahn] > > > > > > On Tue, Mar 16, 2021 at 01:45:51PM +0200, Andy Shevchenko wrote: > > > > On Mon, Mar 15, 2021 at 06:54:24PM -0700, Yury Norov wrote: > > > > > Add myself as maintainer for bitmap API and Andy and Rasmus as reviewers. > > > > > > > > > > I'm an author of current implementation of lib/find_bit and an active > > > > > contributor to lib/bitmap. It was spotted that there's no maintainer for > > > > > bitmap API. I'm willing to maintain it. > > > > > > > > > > Signed-off-by: Yury Norov <yury.norov@xxxxxxxxx> > > > > > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > > Acked-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> > > > > > --- > > > > > MAINTAINERS | 16 ++++++++++++++++ > > > > > 1 file changed, 16 insertions(+) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 3dd20015696e..44f94cdd5a20 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -3151,6 +3151,22 @@ F: Documentation/filesystems/bfs.rst > > > > > F: fs/bfs/ > > > > > F: include/uapi/linux/bfs_fs.h > > > > > > > > > > > > > > > +BITMAP API > > > > > +M: Yury Norov <yury.norov@xxxxxxxxx> > > > > > +R: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > > +R: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> > > > > > +S: Maintained > > > > > +F: include/asm-generic/bitops/find.h > > > > > +F: include/linux/bitmap.h > > > > > +F: lib/bitmap.c > > > > > +F: lib/find_bit.c > > > > > > > > > +F: lib/find_find_bit_benchmark.c > > > > > > > > Does this file exist? > > > > I guess checkpatch.pl nowadays has a MAINTAINER data base validation. > > > > > > No lib/find_find_bit_benchmark.c doesn't exist. It's a typo, it should > > > be lib/find_bit_benchmark.c. Checkpatch doesn't warn: > > > > > > yury:linux$ scripts/checkpatch.pl 0013-MAINTAINERS-Add-entry-for-the-bitmap-API.patch > > > total: 0 errors, 0 warnings, 22 lines checked > > > > checkpatch does not validate filenames for each patch. > > > > checkpatch does have a --self-test=patterns capability that does > > validate file accessibility. > > Joe meant: get_maintainers does have a --self-test=patterns capability > that does validate file accessibility. > > You can run that before patch submission; otherwise, I run that script > on linux-next once a week and send out correction patches as far as my > "spare" time allows to do so. Thanks for the hint. I see it's able to detect the issue.
