On Wed, 2021-03-17 at 16:19 +0200, Octavian Purdila wrote: > > I can understand that your sample code wants btrfs just to show what it > > can do, but IMHO it doesn't make sense to *always* enable it. Btw, what I said there also didn't distinguish between "always enable it" and "always force it enabled". Right now this patch did the latter, but the former might sort of make sense, but would take the form of a defconfig rather than a Kconfig code change. > > I agree. I think these can stay in defconfigs but here is where a > library introduces complications which I don't know how is best to > handle. Should we have the defconfig in arch/um or should we have it > in tools/testing/selftests/um? Or perhaps both places, one being a > generic config that would be used by most applications and one > customized? Yeah, that's a question - and in that sense LKL will never be a general- purpose "library" since then you'd have to basically build it with "allyesconfig" instead of other things. Maybe just put a note there with the tools, and maybe a defconfig, and then have some kind of detection at example/tool build or even runtime that the necessary options are selected? johannes
