On 04/03/2021 22:38, Hector Martin wrote: > This decouples the TTY layer PORT_ types, which are exposed to > userspace, from the driver-internal flag of what kind of port this is. s/This decouples/Decouple > > This removes s3c24xx_serial_has_interrupt_mask, which was just checking s/This removes/Remove/ https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L89 This actually also applies to your patch 19 and 21... and maybe more. > for a specific type anyway. > > Signed-off-by: Hector Martin <marcan@xxxxxxxxx> > --- > drivers/tty/serial/samsung_tty.c | 112 +++++++++++++++++++------------ > 1 file changed, 70 insertions(+), 42 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> Best regards, Krzysztof