On Thu, Feb 4, 2021 at 8:45 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Wed, Feb 3, 2021 at 10:58 PM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: > > > > I guess I need to test harder to get a Tested-by credit :-)? > > You're right Sedat, I'm sorry. Your testing is invaluable; thank you > for taking the time to help and credit is a powerful incentive. > > It can be difficult to know whether to carry forward tags or not when > a patch is revised. > > Keeping track whether someone sent an explicit Tested By vs including > it based on feedback that implied they tried it. If you've tested v7 > or v8, please reply explicitly with tested by tags, or perhaps > Masahiro can apply those for you. > Unfortunately, some recent patches around CBL and kbuild miss my Tested-by's and are already queued up in the remote Git's. Maybe, I was simply pissed off this fact when writing my response to you. Feel free to add my... Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx> # v1-v8 with LLVM/Clang v11.0.1+ & v12.0.0-rc1 amd64 Looking at the (git) diff v7 -> v8 - seen from the code - nothing changed. Feel free to add the links to thread(s) and patch(es) I gave as a feedback in my other response. One reason for missed Tested-by's I see is I am NOT subscribed to some mailing-list. > It can be difficult to know what's broken if you apply too many out of > tree patches though. > "Nicht verkomplifizieren." In English: "R(e)D(u)C(e) complexity" is normally one of my life philosophies. Fighting with... "As usual: It has to work in my development environment - first." Sorry, I insisted that it *has* to work in my environment. It has no secrets - all patches I have queued up in my custom patchset is publically available. That does not mean all of them are or will be upstreamed. Bonne chance with the Linux-BPF folks and send my apologies to have fooled them. It's one of my """strength of character""" (note 3 quotes) :-). - Sedat -
