Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>, Yury Norov <yury.norov@xxxxxxxxx>
Subject: Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Fri, 29 Jan 2021 13:24:09 -0800
Cc: linux-m68k <linux-m68k@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Linux-SH <linux-sh@xxxxxxxxxxxxxxx>, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxx>, Rich Felker <dalias@xxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Dennis Zhou <dennis@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Stefano Brivio <sbrivio@xxxxxxxxxx>, "Ma, Jianpeng" <jianpeng.ma@xxxxxxxxx>, Wei Yang <richard.weiyang@xxxxxxxxxxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <CAHp75VcSc=myrcvyBOkaUDguR6aPjJAFFXi2iSvmU21+1664Hw@mail.gmail.com>
References: <20210129204528.2118168-1-yury.norov@gmail.com> <20210129204528.2118168-4-yury.norov@gmail.com> <CAHp75VcSc=myrcvyBOkaUDguR6aPjJAFFXi2iSvmU21+1664Hw@mail.gmail.com>
User-agent: Evolution 3.38.1-1

On Fri, 2021-01-29 at 23:10 +0200, Andy Shevchenko wrote:
> On Fri, Jan 29, 2021 at 10:49 PM Yury Norov <yury.norov@xxxxxxxxx> wrote:
[]
> > @@ -37,7 +37,7 @@
> >  #define GENMASK(h, l) \
> >         (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
> > 
> > -#define BITS_FIRST(nr)         GENMASK(nr), 0)
> > +#define BITS_FIRST(nr)         GENMASK((nr), 0)
> 
> How come?!

It's broken otherwise with unbalanced parentheses...

References:
- [PATCH 0/6] lib/find_bit: fast path for small bitmaps
  - From: Yury Norov
- [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro
  - From: Yury Norov
- Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH v6 1/2] Kbuild: make DWARF version a choice
Next by Date: Re: [PATCH v6 1/2] Kbuild: make DWARF version a choice
Previous by thread: Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro
Next by thread: Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]