On Thu, Jan 21, 2021 at 2:27 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Wed, Jan 20, 2021 at 04:06:28PM -0800, Yury Norov wrote: > > lib/find_bit.c declares five single-line wrappers for _find_next_bit(). > > We may turn those wrappers to inline functions. It eliminates > > unneeded function calls and opens room for compile-time optimizations. > > ... > > > --- a/include/asm-generic/bitops/le.h > > +++ b/include/asm-generic/bitops/le.h > > @@ -4,6 +4,7 @@ > > > > #include <asm/types.h> > > #include <asm/byteorder.h> > > +#include <asm-generic/bitops/find.h> > > I'm wondering if generic header inclusion should go before arch-dependent ones. > > ... > > > -#ifndef find_next_bit > > > -#ifndef find_next_zero_bit > > > -#if !defined(find_next_and_bit) > > > -#ifndef find_next_zero_bit_le > > > -#ifndef find_next_bit_le > > Shouldn't you leave these in new wrappers as well? > > -- > With Best Regards, > Andy Shevchenko Could you please elaborate? Wrappers in find.h are protected, functions in lib/find_bit.c too. Maybe I misunderstood you?..
