Hi, On Wed, Jan 27, 2021 at 11:55 PM Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> wrote: > > Yuxuan Shui <yshuiv7@xxxxxxxxx> writes: > > > Commit 64eb35f701f04b30706e21d1b02636b5d31a37d2 changed when single step > > is reported. > > > > Specifically, the report_single_step is changed so that single steps are > > only reported when both SYSCALL_EMU and _TIF_SINGLESTEP are set, while > > previously they are reported when _TIF_SINGLESTEP is set without > > _TIF_SYSCALL_EMU being set. > > > > This behavior change breaks rr [1] > > > > This commit restores the old behavior. > > > > [1]: https://github.com/rr-debugger/rr/issues/2793 > > > > Signed-off-by: Yuxuan Shui <yshuiv7@xxxxxxxxx> > > Looks correct to me. > > To gather the right attention, you should directly CC the correct maintainers. Thanks, will do. > > Fixes: 64eb35f701f0 ("ptrace: Migrate TIF_SYSCALL_EMU to use SYSCALL_WORK flag") > Reviewed-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> > > -- > Gabriel Krisman Bertazi -- Regards Yuxuan Shui
