> btrfs' free space cache v1 is going to be removed some time in the > future so introducing kernel-wide change just for its own sake is a bit > premature But, I think it's not quite a kernel-wide change just add the correspondent function to find_last_bit. So, if we add this feature, maybe some users will use it in near future. As my fault, I sent this patch without cover in patch [0/8] to explain why So, I will send this patch again to take some review... Sorry to make a noise again and Thanks to advice. On Sun, Dec 6, 2020 at 6:01 PM Nikolay Borisov <nborisov@xxxxxxxx> wrote: > > > > On 6.12.20 г. 10:56 ч., Yun Levi wrote: > >> This, and the change above this, are not related to this patch so you > >> might not want to include them. > > > >> Also, why is this patch series even needed? I don't see a justification > >> for it anywhere, only "what" this patch is, not "why". > > > > I think the find_last_zero_bit will help to improve in > > 7th patch's change and It can be used in the future. > > But if my thinking is bad.. Please let me know.. > > > > Thanks. > > Levi. > > > > btrfs' free space cache v1 is going to be removed some time in the > future so introducing kernel-wide change just for its own sake is a bit > premature. Also do you have measurements showing it indeed improves > performances?