On 02/12/2020 10.47, Andy Shevchenko wrote: > On Wed, Dec 02, 2020 at 10:10:09AM +0900, Yun Levi wrote: >> Inspired find_next_*bit function series, add find_prev_*_bit series. >> I'm not sure whether it'll be used right now But, I add these functions >> for future usage. > > This patch has few issues: > - it has more things than described (should be several patches instead) > - new functionality can be split logically to couple or more pieces as well > - it proposes functionality w/o user (dead code) Yeah, the last point means it can't be applied - please submit it again if and when you have an actual use case. And I'll add - it lacks extension of the bitmap test module to cover the new functions (that also wants to be a separate patch). Rasmus
