On Fri, Nov 20, 2020 at 11:47:21AM -0800, Kees Cook wrote: > On Fri, Nov 20, 2020 at 08:23:11AM -0800, Sami Tolvanen wrote: > > Changing the ThinLTO config to a choice and moving it after the main > > LTO config sounds like a good idea to me. I'll see if I can change > > this in v8. Thanks! > > Originally, I thought this might be a bit ugly once GCC LTO is added, > but this could be just a choice like we're done for the stack > initialization. Something like an "LTO" choice of NONE, CLANG_FULL, > CLANG_THIN, and in the future GCC, etc. Having two separate choices might be a little bit cleaner though? One for the compiler (LTO_CLANG versus LTO_GCC) and one for the type (THINLTO versus FULLLTO). The type one could just have a "depends on CC_IS_CLANG" to ensure it only showed up when needed. Cheers, Nathan
