On Thu, 2020-10-08 at 22:03 +0300, Octavian Purdila wrote: > On Wed, Oct 7, 2020 at 10:05 PM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Tue, 2020-10-06 at 18:44 +0900, Hajime Tazaki wrote: > > > +++ b/arch/um/nommu/include/uapi/asm/syscalls.h > > > @@ -0,0 +1,287 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > > That doesn't really make sense - if you use LKL you're linking Linux, so > > you can't use this "WITH Linux-syscall-note"? > > > > > +#ifndef __UM_NOMMU_UAPI_SYSCALLS_H > > > +#define __UM_NOMMU_UAPI_SYSCALLS_H > > > > [snip] > > > > This file really worries me, it includes half the world and (re)defines > > the other half ... How is this ever going to be maintained? > > > > There are not that many definitions here, just the ones that were > never defined in uapi headers. And, AFAIK, new code that exposes > structures and data types should always go into uapi headers and not > directly in glibc, etc. So once we fix the old stuff, it should be > fine? Yeah, not really sure. Not all of this is really old stuff, e.g. keyring things were here I noticed. But since it's userspace API I guess the changes of it breaking are fairly small anyway, so maybe I just shouldn't worry about it :) johannes
