On Wed, Oct 7, 2020 at 6:47 PM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Tue, 2020-10-06 at 18:44 +0900, Hajime Tazaki wrote: > > > > * These operations must be provided by a host library or by the application > > * itself. > > * > > + * @mem_alloc - allocate memory > > + * @mem_free - free memory > > + * > > Actual kernel-doc would be nicer. > Thank you, we will make sure to use the proper kernel doc throughout all patches for the next patch series > > + empty_zero_page = memblock_alloc(PAGE_SIZE, PAGE_SIZE); > > + memset((void *)empty_zero_page, 0, PAGE_SIZE); > > + > > + { > > + unsigned long zones_size[MAX_NR_ZONES] = {0, }; > > Hmm, what's with the extra scope? > Will clean it up in the next patch series, thank you.