Hi Chunguang, Thank you for the patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on scsi/for-next block/for-next linus/master asm-generic/master v5.9-rc2 next-20200827] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from net/rxrpc/af_rxrpc.c:10: net/rxrpc/af_rxrpc.c: In function 'rxrpc_listen': >> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'? 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL' 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^~~~~~~~~~~ net/rxrpc/af_rxrpc.c:226:3: note: in expansion of macro 'ASSERT' 226 | ASSERT(rx->local != NULL); | ^~~~~~ net/rxrpc/ar-internal.h:1184:31: note: each undeclared identifier is reported only once for each function it appears in 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL' 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^~~~~~~~~~~ net/rxrpc/af_rxrpc.c:226:3: note: in expansion of macro 'ASSERT' 226 | ASSERT(rx->local != NULL); | ^~~~~~ -- In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from net/rxrpc/call_accept.c:10: net/rxrpc/call_accept.c: In function 'rxrpc_accept_call': >> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'? 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL' 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^~~~~~~~~~~ net/rxrpc/call_accept.c:479:2: note: in expansion of macro 'ASSERT' 479 | ASSERT(!irqs_disabled()); | ^~~~~~ net/rxrpc/ar-internal.h:1184:31: note: each undeclared identifier is reported only once for each function it appears in 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL' 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^~~~~~~~~~~ net/rxrpc/call_accept.c:479:2: note: in expansion of macro 'ASSERT' 479 | ASSERT(!irqs_disabled()); | ^~~~~~ net/rxrpc/call_accept.c: In function 'rxrpc_reject_call': >> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'? 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL' 1184 | #define ASSERT(X) ASSERT_FAIL(x) | ^~~~~~~~~~~ net/rxrpc/call_accept.c:602:2: note: in expansion of macro 'ASSERT' 602 | ASSERT(!irqs_disabled()); | ^~~~~~ # https://github.com/0day-ci/linux/commit/1d215ffa42c9e100fa23c485351acf9293936807 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148 git checkout 1d215ffa42c9e100fa23c485351acf9293936807 vim +1184 net/rxrpc/ar-internal.h 1183 > 1184 #define ASSERT(X) ASSERT_FAIL(x) 1185 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
