On Mon, Jun 08, 2020 at 11:08:04AM +0300, Andy Shevchenko wrote: > On Sun, Jun 7, 2020 at 11:34 PM Rikard Falkeborn > <rikard.falkeborn@xxxxxxxxx> wrote: > > > > Add tests of GENMASK and GENMASK_ULL. > > > > A few test cases that should fail compilation are provided under ifdef. > > > > Thank you very much! > > > * New patch. First time I wrote a KUnittest so may be room for > > improvements... > > Have you considered to unify them with existing test_bitops.h? test_bitops.c seems to be tests for macros/functions in bitops.h, so I figured it would make more sense to add tests of bits.h in test_bits.c. But I don't have a strong opinion about it. If you prefer, I'll move them to test_bitops.c. Rikard > > -- > With Best Regards, > Andy Shevchenko
