Re: [RFC PATCH 4/5] selftest/x86: Fix sysret_rip with ENDBR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Balbir Singh <bsingharora@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Cyrill Gorcunov <gorcunov@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Eugene Syromiatnikov <esyr@xxxxxxxxxx>, Florian Weimer <fweimer@xxxxxxxxxx>, "H.J. Lu" <hjl.tools@xxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Nadav Amit <nadav.amit@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, "Ravi V. Shankar" <ravi.v.shankar@xxxxxxxxx>, Vedvyas Shanbhogue <vedvyas.shanbhogue@xxxxxxxxx>, Dave Martin <Dave.Martin@xxxxxxx>, Weijiang Yang <weijiang.yang@xxxxxxxxx>
Subject: Re: [RFC PATCH 4/5] selftest/x86: Fix sysret_rip with ENDBR
From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Thu, 21 May 2020 23:34:27 +0200
Cc: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
In-reply-to: <20200521211720.20236-5-yu-cheng.yu@intel.com>
References: <20200521211720.20236-1-yu-cheng.yu@intel.com> <20200521211720.20236-5-yu-cheng.yu@intel.com>

Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx> writes:

> Insert endbr64 to assembly code of sysret_rip.

This changelog explains what the patch does, but not the WHY. It also
lacks any information why this is harmless for !CET enabled systems.

> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
> ---

Please consult Dave Hansen about the void between your Signed-off-by
and the '---' line.

Thanks,

        tglx

Follow-Ups:
- Re: [RFC PATCH 4/5] selftest/x86: Fix sysret_rip with ENDBR
  - From: Yu-cheng Yu

References:
- [RFC PATCH 0/5] Update selftests/x86 for CET
  - From: Yu-cheng Yu
- [RFC PATCH 4/5] selftest/x86: Fix sysret_rip with ENDBR
  - From: Yu-cheng Yu

Prev by Date: [RFC PATCH 0/5] Update selftests/x86 for CET
Next by Date: Re: [PATCH v10 26/26] x86/cet/shstk: Add arch_prctl functions for shadow stack
Previous by thread: [RFC PATCH 4/5] selftest/x86: Fix sysret_rip with ENDBR
Next by thread: Re: [RFC PATCH 4/5] selftest/x86: Fix sysret_rip with ENDBR
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]