Re: [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ira Weiny <ira.weiny@xxxxxxxxx>
Subject: Re: [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 24 Feb 2020 22:56:57 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Jonas Bonn <jonas@xxxxxxxxxxxx>, Stefan Kristiansson <stefan.kristiansson@xxxxxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, openrisc@xxxxxxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20200224215327.GB11565@iweiny-DESK2.sc.intel.com>
References: <20200224194446.690816-1-hch@lst.de> <20200224194446.690816-5-hch@lst.de> <20200224215327.GB11565@iweiny-DESK2.sc.intel.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Feb 24, 2020 at 01:53:28PM -0800, Ira Weiny wrote:
> > +	else if (IS_ENABLED(CONFIG_ARCH_HAS_DMA_CLEAR_UNCACHED))
> > +		arch_dma_clear_uncached(cpu_addr, size);
> 
> Isn't using arch_dma_clear_uncached() before patch 5 going to break
> bisectability?

Only if ARCH_HAS_DMA_CLEAR_UNCACHED is selected by anything, which
only happens in patch 5.

References:
- provide in-place uncached remapping for dma-direct v2
  - From: Christoph Hellwig
- [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
  - From: Christoph Hellwig
- Re: [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
  - From: Ira Weiny

Prev by Date: Re: [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
Next by Date: Re: [PATCH v4 05/27] x86: Replace ist_enter() with nmi_enter()
Previous by thread: Re: [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
Next by thread: [PATCH 5/5] openrisc: use the generic in-place uncached DMA allocator
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]