On Fri, Jan 24, 2020 at 12:26 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > On Thu, Jan 23, 2020 at 10:36:37AM -0800, Nick Desaulniers wrote: > > On Thu, Jan 23, 2020 at 7:34 AM Will Deacon <will@xxxxxxxxxx> wrote: > > > > > > It is very rare to see versions of GCC prior to 4.8 being used to build > > > the mainline kernel. These old compilers are also know to have codegen > > > issues which can lead to silent miscompilation: > > > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > > > > > Raise the minimum GCC version for kernel build to 4.8 and remove some > > > tautological Kconfig dependencies as a consequence. > > > > > > Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > Thanks for the patch. > > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > I wouldn't mind if this patch preceded the earlier one in the series > > adding the warning, should the series require a v2 and if folks are > > generally ok with bumping the min version. > > If I hadn't actually read your reply, I would have never spotted that > reviewed-by tag, hidden in a blob of text like that. > > Adding some whitespace before and after, such that it stands out a > little more, might avoid such issues. Ack. Do maintainers have tools for fetching patch series and automating collecting Reviewed-by tags, or is it all extremely manual? -- Thanks, ~Nick Desaulniers
