Sorry for the late reply. I sent this thinking I would check in over
vacation, and then didn't.
On Mon, Dec 16, 2019 at 11:58 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
>
> Quoting Brendan Higgins (2019-12-16 14:05:53)
> > Remove KUnit from init calls entirely, instead call directly from
> > kernel_init().
>
> Yes, but why? Is it desired to run the unit tests earlier than opening
> the console or something?
I want to make sure it is called after late_init is done (so that you
can test things initialized in late_init). And I want to make sure it
runs before init*fs is loaded so that there is a mechanism to run
tests without having to put a userland together.
> > diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
> > index 978086cfd257d..ca880224c0bab 100644
> > --- a/lib/kunit/executor.c
> > +++ b/lib/kunit/executor.c
> > @@ -32,12 +32,10 @@ static bool kunit_run_all_tests(void)
> > return !has_test_failed;
> > }
> >
> > -static int kunit_executor_init(void)
> > +int kunit_executor_init(void)
>
> Should be marked __init? Even before this patch presumably.
Just this function? No strong opinion.
If by "before this patch" you mean other stuff in this patchset?
> > {
> > if (kunit_run_all_tests())
> > return 0;
> > else
> > return -EFAULT;
> > }
> > -
> > -late_initcall(kunit_executor_init);
