On 1/17/20 4:49 AM, Sandipan Das wrote: > Memory protection keys enables an application to protect its address > space from inadvertent access by its own code. > > This feature is now enabled on powerpc and has been available since > 4.16-rc1. The patches move the selftests to arch neutral directory > and enhance their test coverage. > > Tested on powerpc64 and x86_64 (Skylake-SP). I also tested the series. The 64-bit binary works fine. But, This is failing to build the x86 selftests: make: *** No rule to make target 'protection_keys.c', needed by '/home/daveh/linux/tools/testing/selftests/x86/protection_keys_32'. Stop. I think you just forgot to remove the binary from the x86 Makefile. Which reminds me: This removes the 32-bit binary. x86 32-bit binaries exercise different paths than the 64-bit ones, so we like to have both. Although it isn't *essential* it would really be nice to keep the 32-bit binary.