Re: new uses of SYSCTL_SYSCALL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Max Filippov <jcmvbkbc@xxxxxxxxx> writes:

> Hi Eric,
>
> On Tue, Nov 26, 2019 at 11:15 AM Eric W. Biederman
> <ebiederm@xxxxxxxxxxxx> wrote:
>> Doing a test merge against linux-next I see that in the
>> tree git://github.com/jcmvbkbc/linux-xtensa.git#xtensa-for-next
>> a new defconfig is added:
>>
>> arch/xtensa/configs/xip_kc705_defconfig
>>
>> That defconfig adds CONFIG_SYSCTL_SYSCALL.
>>
>> Is xtensa actually using this system call?  So far I have not seen any
>> other users and I am serously proposing to remove it.
>
> I'm sure that this config symbol was inherited from some other config
> that I used as a base for the xip_kc705_defconfig. I didn't enable it
> intentionally. I'll drop it from the config and fix up the patch that
> introduced it.

Thank you for confirming that.

I would recommend an incremental commit/patch on top to change just this
one thing so you don't rebase just before you send a pull request and
cause Linus's to wonder if you have tested the code at all.

Eric




[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux