Hi Andrew, On Sat, Nov 09, 2019 at 03:26:29PM +0100, Geert Uytterhoeven wrote: > Hi Andrew, > > On Fri, Nov 8, 2019 at 8:39 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, 5 Nov 2019 09:15:27 +0200 Mike Rapoport <rppt@xxxxxxxxxx> wrote: > > > m68k has two or three levels of page tables and can use appropriate > > > pgtable-nopXd and folding of the upper layers. > > > > > > Replace usage of include/asm-generic/4level-fixup.h and explicit > > > definitions of __PAGETABLE_PxD_FOLDED in m68k with > > > include/asm-generic/pgtable-nopmd.h for two-level configurations and with > > > include/asm-generic/pgtable-nopud.h for three-lelve configurations and > > > adjust page table manipulation macros and functions accordingly. > > > > This one was messed up by linux-next changes in arch/m68k/mm/kmap.c. > > Can you please take a look? Can you please elaborate what was the problem? The patch applies cleanly to v5.4-rc6-mmots-2019-11-08-16-23 (from github.com/hnaz/linux-mm) and all the page table traversals in arch/m68k/mm/kmap.c look Ok. I've build atari_defconfig and it boots fine on aranym. > You mean due to the rename and move of __iounmap() to __free_io_area() > in commit aa3a1664285d0bec ("m68k: rename __iounmap and mark it static")? > > Commit 42d6c83d6180f800 ("m68k: mm: use pgtable-nopXd instead of > 4level-fixup") in next-20191108 looks good to me. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike.