On Fri, Oct 18, 2019 at 01:37:35PM -0400, Steven Rostedt wrote: > It just needs to be visible by modules and what not, otherwise linking > will fail. And I assume all of them? > The #define was because we use to support mcount or __fentry__, now we > just support __fentry__, and function_hook describes it better ;-) Well sorry but gcc documentation talks about __fentry__. I'd keep the same name to avoid confusion and explain above it what it is. Much better. > Heh, I guess we could, which would probably be quite a long comment as > it's the key behind ftrace itself. Well, you can explain with a couple of sentences what it is and then point at the bigger document explaining ftrace. Provided, Mr. Rostedt, you'll stop doing talks and finally sit down and write that documentation! :-P -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg