On Fri, Oct 11, 2019 at 3:38 PM Vineet Gupta <Vineet.Gupta1@xxxxxxxxxxxx> wrote:
>
> This is inine with similar patches for nopud [1] and nop4d [2] cases.
I don't think your patch is wrong, but wouldn't it be easier and
cleaner to just do this instead
--- a/include/asm-generic/pgtable-nopmd.h
+++ b/include/asm-generic/pgtable-nopmd.h
@@ -60,7 +60,7 @@ static inline pmd_t * pmd_offset(pud_t * pud,
unsigned long address)
static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd)
{
}
-#define __pmd_free_tlb(tlb, x, a) do { } while (0)
+#define pmd_free_tlb(tlb, x, a) do { } while (0)
#undef pmd_addr_end
#define pmd_addr_end(addr, end) (end)
and just rely on the regular "#ifndef pmd_free_tlb" in
include/asm-generic/tlb.h?
Completely untested.
Linus
