On Tue, Oct 1, 2019 at 10:21 PM 'Nick Desaulniers' via Clang Built Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote: > On Tue, Oct 1, 2019 at 11:14 AM Russell King - ARM Linux admin > <linux@xxxxxxxxxxxxxxx> wrote: > > > > On Tue, Oct 01, 2019 at 11:00:11AM -0700, Nick Desaulniers wrote: > > > On Tue, Oct 1, 2019 at 10:55 AM Russell King - ARM Linux admin > > > <linux@xxxxxxxxxxxxxxx> wrote: > > In any case, I violently disagree with the idea that stuff we have > > in header files should be permitted not to be inlined because we > > have soo much that is marked inline. > > So there's a very important subtly here. There's: > 1. code that adds `inline` cause "oh maybe it would be nice to inline > this, but if it isn't no big deal" > 2. code that if not inlined is somehow not correct. > 3. avoid ODR violations via `static inline` > > I'll posit that "we have soo much that is marked inline [is > predominantly case 1 or 3, not case 2]." Case 2 is a code smell, and > requires extra scrutiny. 1. is clearly the most common case, but there is also 4. Some compiler version (possibly long gone, possibly still current) makes bad inlining decisions that result in horrible but functionally correct object code for a particular function, and forcing a function to be inlined results in what we had expected the compiler to do already. The problem with 2. is that they are largely not documented, and often unintentional. This also affects functions that are simply 'static' rather than 'static inline' but are broken when not being inlined. E.g. we've had a number of kernel bugs with 'static __init' functions that gcc always inlined into a non-__init caller, but that produced an invalid call into a discarded function when clang decided to leave them out of line. Arnd