Contrary to the description, the first parameter (n) should not be passed as a pointer, but directly as an lvalue. This is possible because do_div is a macro. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> --- v2: - add Geert Uytterhoeven's R-b v1: - https://lore.kernel.org/lkml/20190225140355.4335-1-j.neuschaefer@xxxxxxx/ --- include/asm-generic/div64.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/asm-generic/div64.h b/include/asm-generic/div64.h index dc9726fdac8f..b2a9c74efa55 100644 --- a/include/asm-generic/div64.h +++ b/include/asm-generic/div64.h @@ -28,12 +28,12 @@ /** * do_div - returns 2 values: calculate remainder and update new dividend - * @n: pointer to uint64_t dividend (will be updated) + * @n: uint64_t dividend (will be updated) * @base: uint32_t divisor * * Summary: - * ``uint32_t remainder = *n % base;`` - * ``*n = *n / base;`` + * ``uint32_t remainder = n % base;`` + * ``n = n / base;`` * * Return: (uint32_t)remainder * -- 2.20.1
