Hi Will, On 19/07/2019 09:04, Will Deacon wrote: > On Thu, Jul 18, 2019 at 12:41:21PM +0100, Vincenzo Frascino wrote: >> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile >> index 21009ed5a755..6c4e496309c4 100644 >> --- a/arch/arm64/kernel/vdso32/Makefile >> +++ b/arch/arm64/kernel/vdso32/Makefile >> @@ -155,17 +155,17 @@ $(asm-obj-vdso): %.o: %.S FORCE >> $(call if_changed_dep,vdsoas) >> >> # Actual build commands >> -quiet_cmd_vdsold_and_vdso_check = LD $@ >> +quiet_cmd_vdsold_and_vdso_check = VDSOLIB $@ >> cmd_vdsold_and_vdso_check = $(cmd_vdsold); $(cmd_vdso_check) >> >> -quiet_cmd_vdsold = VDSOL $@ >> +quiet_cmd_vdsold = VDSOLD $@ > > I think we should be more consistent about whether or not we prefix things > with VDSO, so either go with "VDSOLD, VDSOCC and VDSOAS" or stick to "LD, > CC and AS" rather than mixing between them. > > I think my suggestion would be something along the lines of CC, LD, AS for > the native vdso and CC32, LD32, AS32 for the compat vdso. > Sounds good. I will send v2 accordingly. > Will > -- Regards, Vincenzo
